Re: Follow-up on "Query tool layout issues" - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject Re: Follow-up on "Query tool layout issues"
Date
Msg-id 4B9570A1.3050305@lelarge.info
Whole thread Raw
In response to Re: Follow-up on "Query tool layout issues"  (Dave Page <dpage@pgadmin.org>)
Responses Re: Follow-up on "Query tool layout issues"
List pgadmin-hackers
Le 08/03/2010 21:05, Dave Page a écrit :
> On Mon, Mar 8, 2010 at 6:04 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>
>> I'll try to do something based on that. My first idea was something like
>> wxPropertyGrid
>> (http://wxpropgrid.sourceforge.net/cgi-bin/index?page=about), I suppose
>> also this is what you wanted to say with the VisualStudio stuff.
>
> Yeah, thats the sort of thing. Shame it's another external library
> though :-(. Think I'd prefer to avoid that.
>

So do I.

There's another/simpler way to do it. We just need to change the
wxNotebook's style to wxNB_LEFT (one line to add), and we have something
fine. See the screenshot attached (but keep in mind I can't check right
now on Windows and Mac OS X).

Yet another way would be to replace the wxNotebook with a wxAUINotebook.

In fact, my proposal would be to:
 * use wxNB_LEFT for 1.12 ;
 * think about replacing it with something else for 1.14.

>> OK, commit done. I did one commit per patch because I find it easier to
>> understand the different steps.
>
> Absolutely the correct approach. Never mix patches in one commit. :-)
>

Sure. But it was a lot of commits at the same time.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Attachment

pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Re: SVN Commit by guillaume: r8217 - in tags/REL-1_10_2: . pgadmin3 pgadmin3/i18n/af_ZA pgadmin3/i18n/ar_SA pgadmin3/i18n/bg_BG pgadmin3/i18n/ca_ES pgadmin3/i18n/cs_CZ pgadmin3/i18n/da_DK pgadmin3/i18n/de_CH pgadmin3/i18n/de_DE pgadmin3/i18n/el_GR pgadmin3/i18n/es_ES pgadmin3/i18n/fa_IR pgadmin3/i18n/fi_FI pgadmin3/i18n/fr_FR pgadmin3/i18n/gl_ES pgadmin3/i18n/gu_IN pgadmin3/i18n/hi_IN pgadmin3/i18n/hr_HR pgadmin3/i18n/hu_HU pgadmin3/i18n/id_ID pgadmin3/i18n/is_IS pgadmin3/i18n/it_IT pgadmin3/i18n/ja_JP pgadmin3/i18n/ko_KR pgadmin3/i18n/lt_LT pgadmin3/i18n/lv_LV pgadmin3/i18n/mk_MK pgadmin3/i18n/nb_NO pgadmin3/i18n/nl_NL pgadmin3/i18n/pl_PL pgadmin3/i18n/pt_BR pgadmin3/i18n/pt_PT pgadmin3/i18n/ro_RO pgadmin3/i18n/ru_RU pgadmin3/i18n/sk_SK pgadmin3/i18n/sl_SI pgadmin3/i18n/sr_RS pgadmin3/i18n/sv_SE pgadmin3/i18n/te_IN pgadmin3/i18n/tl_PH pgadmin3/i18n/tr_TR pgadmin3/i18n/uk_UA pgadmin3/i18n/ur_PK pgadmin3/i18n/vi_VN pgadmin3/i18n/zh_CN pgadmin3/i18n/zh_TW pgadmin3/pgadmin! /include
Next
From: "pgAdmin Trac"
Date:
Subject: Re: [pgAdmin III] #143: Replace wxColourPicker with a custom one