Re: Patch: Remove gcc dependency in definition of inline functions - Mailing list pgsql-hackers

On 1/18/2010 11:48 PM, Peter Eisentraut wrote:
> On mån, 2010-01-18 at 16:34 -0800, Kurt Harriman wrote:
>> MSVC does warn about unused static inline functions.  The warning
>> is prevented by using __forceinline instead of __inline.
>
> Hmm, but forceinline is not the same as inline.  Are we confident that
> forcing inlining is not going to lead to disadvantages?  Has this been
> measured?
>
> Is there not a setting to disable this particular warning.  I read that
> MSVC has various ways to set that sort of thing.

On further investigation, plain __inline works alright, at least in
Visual Studio 2005.  The warning for unused static inline functions
only comes up when compiling C++, not C.  I've submitted a revised
patch, no longer using __forceinline.

Regards, ... kurt