Re: Some belated patch review for "Buffers" explain analyze patch - Mailing list pgsql-hackers

From Josh Berkus
Subject Re: Some belated patch review for "Buffers" explain analyze patch
Date
Msg-id 4B71C4F5.2000506@agliodbs.com
Whole thread Raw
In response to Some belated patch review for "Buffers" explain analyze patch  (Greg Stark <stark@mit.edu>)
Responses Re: Some belated patch review for "Buffers" explain analyze patch
List pgsql-hackers
On 2/9/10 11:50 AM, Greg Stark wrote:
> Secondly, I think it's printing the total buffer usage for that node
> across the whole query -- not the average per iteration. I agree that
> the average is probably more confusing but it's what we do for every
> other stat. Do we want to be consistent? Call out the inconsistency
> somehow, perhaps by tagging it "Total Buffer Usage:" or something like
> that?

I'd prefer to have the average; it's very confusing to have an explain
row which has the cost per iteration, but the buffer usage per node.

--Josh Berkus


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: CreateFakeRelcacheEntry versus Hot Standby
Next
From: Etienne Dube
Date:
Subject: Re: [PATCH] "could not reattach to shared memory" on Windows