Re: Order of operations in lazy_vacuum_rel - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Order of operations in lazy_vacuum_rel
Date
Msg-id 4B706D81.7010600@enterprisedb.com
Whole thread Raw
In response to Re: Order of operations in lazy_vacuum_rel  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Alvaro Herrera wrote:
> Tom Lane wrote:
>> The point would be to not disable interrupts till after doing the FSM
>> vacuuming.  Ignoring CANCEL for longer than we must is bad.
> 
> Oh, I see.  I guess the answer is that it depends on what happens if you
> interrupt after vacuuming the FSM.  I have no idea what that is supposed
> to accomplish so I'm of no help here.  FreeSpaceMapVacuum says it's
> about fixing inconsistencies in the FSM, so I'm guessing that it's not
> critical.

Yeah, interrupting FreeSpaceMapVacuum (or right after it) is harmless.

> FWIW I notice that RelationTruncate contains an outdated comment at the
> top about the 'fsm' function argument which is nowadays no longer an
> argument.

Thanks, fixed.

--  Heikki Linnakangas EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Florian Weimer
Date:
Subject: Re: Confusion over Python drivers
Next
From: Alvaro Herrera
Date:
Subject: Re: [CFReview] Red-Black Tree