Re: Review of Writeable CTE Patch - Mailing list pgsql-hackers

From Marko Tiikkaja
Subject Re: Review of Writeable CTE Patch
Date
Msg-id 4B6A00DF.1030006@cs.helsinki.fi
Whole thread Raw
In response to Re: Review of Writeable CTE Patch  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Hi,

Attached is an updated patch.  I'm now going to start working on the
documentation and I'll send it in a separate patch a bit later.

On 2010-02-03 16:53 UTC+2, Robert Haas wrote:
> Some thoughts:

> This patch
> removes a number of other assertions as well, but I don't know enough
> about those other spots to judge whether all of those cases are
> sensible.

I put back the Asserts in make_modifytable().  The one in
ExecInitModifyTable() is not true any more and neither is the Assert in
transformInsertStatement().


Regards,
Marko Tiikkaja

Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: PG 9.0 and standard_conforming_strings
Next
From: Andrew Dunstan
Date:
Subject: Re: Add on_trusted_init and on_untrusted_init to plperl UPDATED [PATCH]