Re: Ticket 117: Explain Buffers - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject Re: Ticket 117: Explain Buffers
Date
Msg-id 4B69D0E4.2030104@lelarge.info
Whole thread Raw
In response to Re: Ticket 117: Explain Buffers  (Guillaume Lelarge <guillaume@lelarge.info>)
List pgadmin-hackers
Le 26/01/2010 10:18, Guillaume Lelarge a écrit :
> Le 26/01/2010 04:13, Euler Taveira de Oliveira a écrit :
>> Guillaume Lelarge escreveu:
>>> New patch attached.
>>>
>> Nice job. But there are just a few gripes about your patch: (i) it doesn't
>> disable the EXPLAIN button when the BUFFERS option is enabled, (ii) it doesn't
>> disable the EXPLAIN ANALYZE menu when the query is running, and (iii) there is
>> a bug when the BUFFERS option is enabled and you close and open the query tool
>> again (the EXPLAIN menu turns enabled instead of disabled).
>>
>> The attached patch (on the top of your patch) addresses all of these problems.
>>
>
> Thanks a lot for your help. I added your patch, here is the new complete
> patch.
>
> Seems good to me. Any more comments before I apply it?
>

Commited.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

pgadmin-hackers by date:

Previous
From: svn@pgadmin.org
Date:
Subject: SVN Commit by guillaume: r8172 - in trunk/pgadmin3: . pgadmin/ctl pgadmin/frm pgadmin/include/frm pgadmin/include/utils
Next
From: "pgAdmin Trac"
Date:
Subject: Re: [pgAdmin III] #117: Explain Buffers