Re: pgsql: Rethink the way walreceiver is linked into the backend. Instead - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Rethink the way walreceiver is linked into the backend. Instead
Date
Msg-id 4B56F03B.1020200@enterprisedb.com
Whole thread Raw
In response to Re: pgsql: Rethink the way walreceiver is linked into the backend. Instead  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-committers
Fujii Masao wrote:
> And I found the small bug. Could you fix it?
>
> src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
>> _PG_init(void)
>> {
>>     /* Tell walreceiver how to reach us */
>>     if (walrcv_connect != NULL || walrcv_receive != NULL || walrcv_disconnect)
>>         elog(ERROR, "libpqwalreceiver already loaded");
>
> In the above branch on condition, the "walrcv_disconnect" should be compared
> with "NULL".

Thanks. "walrcv_disconnect" has the same effect as "walrcv_disconnect !=
NULL", but fixed for the sake of consistency.

--
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

pgsql-committers by date:

Previous
From: heikki@postgresql.org (Heikki Linnakangas)
Date:
Subject: pgsql: Add missing "!= NULL", for the sake of consistency.
Next
From: heikki@postgresql.org (Heikki Linnakangas)
Date:
Subject: pgsql: Now that much of walreceiver has been pulled back into the