Re: SVN Commit by guillaume: r8145 - in trunk/pgadmin3: . pgadmin/db pgadmin/frm - Mailing list pgadmin-hackers

Le 03/01/2010 10:55, Dave Page a écrit :
> On Sat, Jan 2, 2010 at 9:57 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>
>> OK. Here is a new patch which calls PQconninfoParse and acts according
>> to its return code. It also removes part of the old patch.
>>
>> Is it better?
>
> Certainly looks more as I imagined. There is a little inconsistency though:
>
> +            wxString applicationname = wxT("pgAdmin (Query Tool)");
>
> ...
>
> +    wxString applicationname = wxT("pgAdmin - Query Tool");
>

Will fix this.

> Also, doesn't the debugger falback to the libc encoding as the main
> connection class does?
>

It didn't have the fallback libc encoding code before I began to work on
this, so I didn't add it. But I can add that pretty easily.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com