Re: test/example does not support win32. - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: test/example does not support win32.
Date
Msg-id 4B3B7A50.4090905@dunslane.net
Whole thread Raw
In response to Re: test/example does not support win32.  ("Hiroshi Saito" <z-saito@guitar.ocn.ne.jp>)
List pgsql-hackers

Hiroshi Saito wrote:
> Hi Andrew-san.
>
> Although this is a standard in windows.
>
> *** testlibpq2.c.orig   Wed Dec 30 13:19:03 2009
> --- testlibpq2.c        Thu Dec 31 00:52:52 2009
> ***************
> *** 24,34 ****
> --- 24,39 ----
>   *
>   *     INSERT INTO TBL1 VALUES (10);
>   */
> +
> + #ifdef WIN32
> + #include <windows.h>
> + #endif
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <string.h>
>  #include <errno.h>
>  #include <sys/time.h>
> + #include <sys/types.h>
>  #include "libpq-fe.h"
>
>  static void
>
> Does this become the standard which you consider?
> or #IFDEF Isn't it allowed?
>
>
I certainly think we can use ifdefs. This addition seems OK to me at 
first glance. Does it solve the problem you encountered?

cheers

andrew


pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: Thoughts on statistics for continuously advancing columns
Next
From: Tom Lane
Date:
Subject: Re: test/example does not support win32.