Re: LIKE INCLUDING COMMENTS code is a flight of fancy - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: LIKE INCLUDING COMMENTS code is a flight of fancy
Date
Msg-id 4B313065.3050309@dunslane.net
Whole thread Raw
In response to Re: LIKE INCLUDING COMMENTS code is a flight of fancy  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: LIKE INCLUDING COMMENTS code is a flight of fancy  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

Tom Lane wrote:
>
> I'm for forbidding comments on index columns.  The amount of work
> required to support the feature fully seems far out of proportion to
> its value.
>
> In any case, if pg_dump drops such comments (which I had forgotten,
> but it seems true after a quick look at the code), then we could
> certainly get away with having LIKE not copy them.  That would fix
> the immediate problem.
>
>             
>   

If we're going to keep the comments we should dump them. I don't mind 
dropping them altogether - it's hardly a killer feature. We should just 
be consistent, IMNSHO.

cheers

andrew


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Backup history file should be replicated in Streaming Replication?
Next
From: Tom Lane
Date:
Subject: Re: Tuplestore should remember the memory context it's created in