Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Fix a violation of WAL coding rules in the recent patch to - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Fix a violation of WAL coding rules in the recent patch to
Date
Msg-id 4A9227A1.3020603@enterprisedb.com
Whole thread Raw
In response to pgsql: Fix a violation of WAL coding rules in the recent patch to  (tgl@postgresql.org (Tom Lane))
List pgsql-committers
Tree view 
Tom Lane wrote:
> Log Message:
> -----------
> Fix a violation of WAL coding rules in the recent patch to include an
> "all tuples visible" flag in heap page headers.  The flag update *must*
> be applied before calling XLogInsert, but heap_update and the tuple
> moving routines in VACUUM FULL were ignoring this rule.  A crash and
> replay could therefore leave the flag incorrectly set, causing rows
> to appear visible in seqscans when they should not be.  This might explain
> recent reports of data corruption from Jeff Ross and others.

Ouch! Yeah, the old code would write full-page images with the flag
incorrectly set.

Thanks!

--
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Run the "tablespace" regression test first not last.
Next
From: Heikki Linnakangas
Date:
Subject: Re: pgsql: Fix a violation of WAL coding rules in the recent patch to