Re: WIP: to_char, support for EEEE format - Mailing list pgsql-hackers

From Euler Taveira de Oliveira
Subject Re: WIP: to_char, support for EEEE format
Date
Msg-id 4A70777A.8020706@timbira.com
Whole thread Raw
In response to Re: WIP: to_char, support for EEEE format  (Brendan Jurd <direvus@gmail.com>)
Responses Re: WIP: to_char, support for EEEE format  (Brendan Jurd <direvus@gmail.com>)
List pgsql-hackers
Brendan Jurd escreveu:
> Filling unused characters in the string with "#" may be strange, but
> changing it would require a much broader patch that covers all of the
> numeric formatting styles, not just EEEE.  A TODO is probably the way
> to go.
> 
That was my suggestion: a TODO.

> So if you put the test inside the switch, it would need to appear in
> every single branch of the switch except for the NUM_E one.  I'm
> confused about why you think this needs a comment.  Perhaps I
> misunderstood you?
> 
Yes, I know you need to modify every 'case' clause to test if EEEE was
previously used (that was one suggestion) but I said if you don't want to go
that way, add a comment explaining why you're using that 'if' above the
'switch' and not inside it.


--  Euler Taveira de Oliveira http://www.timbira.com/


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: system timezone regression failure
Next
From: Tom Lane
Date:
Subject: Re: system timezone regression failure