Re: [PATCH] Beautify line-ends handling yet more. - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [PATCH] Beautify line-ends handling yet more.
Date
Msg-id 4A470437-1E4F-47E1-ACC8-D42491F5BB31@pgadmin.org
Whole thread Raw
In response to Re: [PATCH] Beautify line-ends handling yet more.  (Nikolai Zhubr <n-a-zhubr@yandex.ru>)
Responses Re: [PATCH] Beautify line-ends handling yet more.  (Nikolai Zhubr <n-a-zhubr@yandex.ru>)
Re: [PATCH] Beautify line-ends handling yet more.  (Szabolcs Hubai <szab.hu@gmail.com>)
List pgadmin-hackers

> On 10 Oct 2015, at 13:33, Nikolai Zhubr <n-a-zhubr@yandex.ru> wrote:
>
> Hello Dave,
> 09.10.2015 16:31, Dave Page wrote:
> [...]
>> I committed a modified version of this - Mac OS X uses \n as a
>> line-end, so that makes a better default than the old-style \r used on
>> Mac classic.
>
> Ah, I didn't know that, thanks for explanation.
>
> I suppose it is unlikely someone will use current (and future) releases of pgamin3 on Mac classic, therefore I'd
proposeto also update the corresponding preferences menu. Right now it shows 3 possibilities: 
>
> * Unix (LF)
> * DOS (CRLF)
> * Mac (CR)
>
> Maybe it would make sense to only provide 2 with the following naming:
>
> * Unix/Mac (LF)
> * DOS/Windows (CRLF)
>
> If it is OK then I'll craft a git diff for that (eventually).

I'm not sure we should - it may be useful for someone working with legacy systems, and it's not like it's a massive
amountof code bloating the app or overly complicating the UI. 

pgadmin-hackers by date:

Previous
From: Nikolai Zhubr
Date:
Subject: Re: [PATCH] Beautify line-ends handling yet more.
Next
From: Nikolai Zhubr
Date:
Subject: Re: [PATCH] Beautify line-ends handling yet more.