Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> The second question is, is it worth doing this so extremely late in the
>> 8.4 development? After mentioning it quickly in an offlist discussion
>> with Heikki, I think our conclusion was that we should wait with this
>> until the tree opens for 8.5.
>
> +1. This is barely even a bug; it's not worth taking any risk for at
> this point. (It is already too late for a patch applied now to be
> tested by the whole buildfarm before we wrap 8.4.0 --- some machines
> are on a once-a-day cycle.)
Yeah, that was our reasoning as well.
Attached is a patch that takes them both away, so I have something to
put on the wiki :-)
--
Magnus Hagander
Self: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
Index: Makefile
===================================================================
RCS file: /cvsroot/pgsql/contrib/pg_standby/Makefile,v
retrieving revision 1.4
diff -c -r1.4 Makefile
*** Makefile 10 Nov 2007 23:59:51 -0000 1.4
--- Makefile 25 Jun 2009 13:32:08 -0000
***************
*** 3,11 ****
PROGRAM = pg_standby
OBJS = pg_standby.o
- PG_CPPFLAGS = -I$(libpq_srcdir)
- PG_LIBS = $(libpq_pgport)
-
ifdef USE_PGXS
PG_CONFIG = pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs)
--- 3,8 ----
