Re: GetTokenInformation() and FreeSid() at port/exec.c - Mailing list pgsql-bugs

From Andrew Chernow
Subject Re: GetTokenInformation() and FreeSid() at port/exec.c
Date
Msg-id 4A40EF9A.2030409@esilo.com
Whole thread Raw
In response to Re: GetTokenInformation() and FreeSid() at port/exec.c  (Magnus Hagander <magnus@hagander.net>)
Responses Re: GetTokenInformation() and FreeSid() at port/exec.c  (Magnus Hagander <magnus@hagander.net>)
List pgsql-bugs
>
> How about something like this? I switched to using LocalAlloc() in all
> places to be consistent, instead of mixing heap and local. (Though per
> doc, LocalAlloc is actually a wrapper for HeapAlloc in win32).

Our patches crossed.  Although, in my patch I left the allocation scheme
alone since I wasn't sure if someone wanted that way.  I'd suggest
malloc and free if your going to change it.  The only time I use an MS
allocater is when a win32 api function specifically states it must be used.

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

pgsql-bugs by date:

Previous
From: Andrew Chernow
Date:
Subject: Re: GetTokenInformation() and FreeSid() at port/exec.c
Next
From: Tom Lane
Date:
Subject: Re: BUG #4872: Geometric function problem