Re: It's June 1; do you know where your release is? - Mailing list pgsql-hackers

Magnus Hagander wrote:
> Andrew Dunstan wrote:
>   
>> Magnus Hagander wrote:
>>     
>>> Dave Page wrote:
>>>  
>>>       
>>>> On Thu, Jun 4, 2009 at 12:40 AM, Andrew Dunstan <andrew@dunslane.net>
>>>> wrote:
>>>>    
>>>>         
>>>>> Of course, that leaves the issue of the library name to be fixed, but
>>>>> sufficient unto the day ...
>>>>>       
>>>>>           
>>>> Yeah - I chatted briefly with Magnus about that a while back. I added
>>>> a quick hack to Mkvcbuild.pm to allow it to use either 5.10 or 5.8,
>>>> but didn't even think about the msys build.
>>>>
>>>>     
>>>>         
>>> Yeah, this is something we need to look at for 8.5. I think it's too
>>> late in the cycle to start messing with it for 8.4.
>>>   
>>>       
>> I don't see why. Perl 5.10 is out there and people will want to use it.
>> I have a simple fix for this in GNUMakefile (see below) , and putting
>> something similar in the MSVC build stuff will be simple too. If we
>> don't want to support Perl 5.10 why was the item on the open issues list
>> at all (and why did I just spend hours finding a solution to the hard
>> part)?
>>     
>
> I mostly meant a general make-it-version-independent fix. The fix that's
> in the MSVC build system now is really just a hack that only supports
> 5.8 and 5.10, not any other versions.
>
> But sure, if it's that easy, go for it :-)
>   

Yeah. The patch below should be far more future-proof (and past-proof, 
for that matter).

Dave, any chance you can test it?

cheers

andrew


Index: src/tools/msvc/Mkvcbuild.pm
===================================================================
RCS file: /cvsroot/pgsql/src/tools/msvc/Mkvcbuild.pm,v
retrieving revision 1.39
diff -c -r1.39 Mkvcbuild.pm
*** src/tools/msvc/Mkvcbuild.pm 7 Apr 2009 19:35:57 -0000       1.39
--- src/tools/msvc/Mkvcbuild.pm 4 Jun 2009 16:19:29 -0000
***************
*** 104,116 ****             }         }         $plperl->AddReference($postgres);
!         if (-e $solution->{options}->{perl} . '\lib\CORE\perl510.lib')         {
!             $plperl->AddLibrary($solution->{options}->{perl} . 
'\lib\CORE\perl510.lib');
!         }
!         else
!         {
!             $plperl->AddLibrary($solution->{options}->{perl} . 
'\lib\CORE\perl58.lib');         }     }
--- 104,114 ----             }         }         $plperl->AddReference($postgres);
!               my @perl_libs =
!                       glob($solution->{options}->{perl} . 
'\lib\CORE\perl*.lib');
!         if (@perl_libs == 1)         {
!             $plperl->AddLibrary($perl_libs[0]);         }     }