Simon Riggs wrote:
> On Thu, 2009-05-28 at 16:52 +0300, Heikki Linnakangas wrote:
>
>>> If the archiver is working, but has fallen behind at the point of
>>> shutdown, does the archiver operate for long enough to ensure we are
>>> archived up to the point of the log switch prior to checkpoint?
>> Yes, it archives all pending WAL segments before exiting.
>
> I don't think it does, please look again.
Still looks ok to me. pgarch_ArchiverCopyLoop() loops until all ready
WAL segments have been archived (assuming no errors).
>> Ok, we're good then I guess.
>
> No, because as I said, if archive_command has been returning non-zero
> then the archive will be incomplete.
Yes. You think that's wrong? How would you like it to behave, then? I
don't think you want the shutdown to wait indefinitely until all files
have been archived if there's an error.
-- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com
