Re: Compiler warning - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Compiler warning
Date
Msg-id 4A13C3E2.8000200@enterprisedb.com
Whole thread Raw
In response to Compiler warning  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: Compiler warning  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Fujii Masao wrote:
> I encountered the following compiler warning in 8.4dev.
> Attached is the patch to fix this problem. Is this worth committing?
> 
> ------------------
> tablecmds.c: In function 'DropErrorMsgWrongType':
> tablecmds.c:606: warning: format not a string literal and no format arguments
> ------------------

Hmm, it is a false alarm, but would be nice to have a warning-free 
build. I don't see that warning here on gcc 4.3.3 by default, but I do 
when I set -Wformat-security. I presume you had that set as well.

Applied.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Multiple sorts in a query
Next
From: Stefan Keller
Date:
Subject: Re: Proposal: functions get_text() or get_url()