On 04.12.25 08:09, Bilal Yavuz wrote:
> 0001 adds python_includespec and perl_includespec variables to the
> Makefile.global of the meson build.
Committed that, with some light cosmetic ordering changes.
> 0002 adds headerscheck target to meson build like you do but with 2
> extra changes. First one is that, I moved the headerscheck script to a
> variable and used it in the target commands. Second one is that,
> headerscheck script could not find the perl_includespec and
> python_includespec variables because of the tabs in the sed command, I
> changed them with '[:space:]' and it worked. I am not sure if that is
> the correct fix but I just wanted to see if the script will work.
Committed that, but without the regular expression changes. I don't
understand why those would be needed. Please provide more information
if necessary. It worked for me without it.
> 0003 adds icu_flags option to the meson build and sets 'ICU_CFLAGS'
> Makefile.global variable to that option. This change is not needed for
> the headerscheck script to work but I saw that was missing and just
> wanted to show it. If we want to add that, this probably needs its own
> thread.
I don't think we want that. We want to encourage the use of pkg-config,
not the previous legacy options.
