Code review in dsa.c - Mailing list pgsql-hackers

From Zhang Mingli
Subject Code review in dsa.c
Date
Msg-id 49bebf7a-059a-4750-ba30-3fe0a734e4e9@Spark
Whole thread Raw
Responses Re: Code review in dsa.c
List pgsql-hackers
Hi, hackers

Found  some functions in dsa.c are not used anymore.

dsa_create
dsa_attach
dsa_get_handle
dsa_trim
dsa_dump

We once used dsa_create to create DSA and  it ’s all replaced by dsa_create_in_place since commit 31ae1638ce.
dsa_attach and dsa_get_handle cooperate with dsa_create.
dsa_trim and dsa_dump are introduced by DSA original commit 13df76a537 , but not used since then.

So, they are all dead codes, provide a patch to remove them.

Regards,
Zhang Mingli
Attachment

pgsql-hackers by date:

Previous
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: logrep stuck with 'ERROR: int2vector has too many elements'
Next
From: Tom Lane
Date:
Subject: Re: Extracting cross-version-upgrade knowledge from buildfarm client