Re: Keyword list sanity check - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Keyword list sanity check
Date
Msg-id 49F97DAA.8060706@enterprisedb.com
Whole thread Raw
In response to Re: Keyword list sanity check  (David Fetter <david@fetter.org>)
List pgsql-hackers
David Fetter wrote:
> Please clean up this code at least to the point where it's
> strict-clean, which means putting "use strict;" right after the
> shebang line and not checking it in until it runs that way.
> 
> I tried, but couldn't make heads or tails of the thing, given all the
> unused- and similarly-named variables, failure to indent, etc.  I
> don't know how to put this gently, but if you checked in C code with
> quality like this, you'd have it bounced with derision.

Yep, I'm completely novice at perl. I've checked in Laurent's patch to 
clean it up, which at least makes it strict-clean.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Itagaki Takahiro
Date:
Subject: Re: Creating a tablespace directory in recovery
Next
From: Tom Lane
Date:
Subject: Re: idea: global temp tables