Re: Debugger hung on dummy function - Mailing list pgadmin-hackers

From Heikki Linnakangas
Subject Re: Debugger hung on dummy function
Date
Msg-id 49DA641C.20009@enterprisedb.com
Whole thread Raw
In response to Re: Debugger hung on dummy function  (Dave Page <dpage@pgadmin.org>)
Responses Re: Debugger hung on dummy function
Re: Debugger hung on dummy function
List pgadmin-hackers
Dave Page wrote:
> Hi Heikki
>
> On Fri, Apr 3, 2009 at 4:43 PM, Heikki Linnakangas
> <heikki.linnakangas@enterprisedb.com> wrote:
>> CREATE FUNCTION onelinefunc() RETURNS void AS $$ begin null; end; $$
>> LANGUAGE plpgsql;
>
> Debugging that won't work terribly well anyway, as the plugin will
> just skip the entire function iirc. For slightly saner testing, try
> replacing null; with raise notice 'foo';. I'm not inclined to spend
> the time fixing the first case at the moment as it seems unlikely to
> ever cause anyone problems.

It's reproducible with any other function too, by stepping to the end of
the function. Which suggests that the problem occurs when the dialog is
displayed for the 2nd time.

>> When I choose Debugging->debug on that function, pgAdmin hangs, consuming
>> 100% of CPU. This is on latest svn version of pgAdmin, running on Debian
>> linux with wxwidgets 2.8.10.
>>
>> The same doesn't happen if the function takes an argument:
>>
>> CREATE FUNCTION onelinefunc(i integer) RETURNS void AS $$ begin null; end;
>> $$ LANGUAGE plpgsql;
>>
>> The same thing happens even if the function has more interesting contents,
>> when I step to the end of the function.
>
> Hmm, that's pretty weird. I can't reproduce it here, however I'm on
> CentOS 5.2 x86_64 which currently only has wxWidgets 2.8.9.

Probably some gtk/wxwidgets glitch. The backtrace suggests that theme
might make a difference too..

> The line
> you've commented out simply sizes the grid so that the 'No arguments
> required' text fits in the first column. Does the following change
> work for you?
>
> --- debugger/dlgDirectDbg.cpp   (revision 7789)
> +++ debugger/dlgDirectDbg.cpp   (working copy)
> @@ -295,7 +295,7 @@
>         font.SetStyle( wxFONTSTYLE_ITALIC );
>         grdParams->SetCellFont( 0, COL_NAME, font );
>
> -        grdParams->AutoSizeColumns();
> +       grdParams->SetColSize( COL_NAME, 200 );
>         activateDebugger();
>     }
>     else

Yes! That fixes it.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: EXPLAIN format changes
Next
From: Heikki Linnakangas
Date:
Subject: Re: Debugger hung on dummy function