Re: pgsql: Make directory name comparisons on Win32 case insensitive. - Mailing list pgsql-committers

From Magnus Hagander
Subject Re: pgsql: Make directory name comparisons on Win32 case insensitive.
Date
Msg-id 49D7128B.5070009@hagander.net
Whole thread Raw
In response to Re: pgsql: Make directory name comparisons on Win32 case insensitive.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tom Lane wrote:
> mha@postgresql.org (Magnus Hagander) writes:
>> Log Message:
>> -----------
>> Make directory name comparisons on Win32 case insensitive.
>
> Hmm, for consistency you really should be doing
>     pg_tolower((unsigned char) *foo)
> here.
>
> It's possible that the cast is not necessary on Windows, but
> even so code consistency is a good thing.

I see you've fixed this, thanks.

//Magnus


pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Rewrite interval_hash() so that the hashcodes are equal for
Next
From: hinoue@pgfoundry.org (User Hinoue)
Date:
Subject: psqlodbc - psqlodbc: Improve the transactional control under