Re: PQinitSSL broken in some use casesf - Mailing list pgsql-hackers

From Andrew Chernow
Subject Re: PQinitSSL broken in some use casesf
Date
Msg-id 49CE6C85.9040806@esilo.com
Whole thread Raw
In response to Re: PQinitSSL broken in some use casesf  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> 
> I personally would be happy with the two-argument function solution.
> 

The patch I submitted pretty much does this, except it uses a flags argument 
instead of 2 fixed arguments.  It can be easily changed to support the 2 
argument idea:

1. Change prototype to: void PQinitSecure(int ssl, int crypto);  - previous return value can go away, new version can
bevoid.
 
2. Remove PG_SECURE_SSL, PG_SECURE_CRYPTO from libpq-fe.h
3. Modify wrapping code in PQinitSSL to use new prototype.  - either pass 0,0 or 1,1, to PQinitSecure.

Outside of that, the patch goes unchanged.

-- 
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: PQinitSSL broken in some use casesf
Next
From: Bruce Momjian
Date:
Subject: Re: PQinitSSL broken in some use casesf