Re: GIN fast insert - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: GIN fast insert
Date
Msg-id 49C8F898.1020401@sigaev.ru
Whole thread Raw
In response to Re: GIN fast insert  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: GIN fast insert  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> Why is tbm_add_page() not coded as a simple wrapper around
> tbm_mark_page_lossy()?  As coded, it sometimes forces a whole bunch of
> pages *other than* the target page to become lossy too, which I cannot
> see a reason for it to be doing.

[after digging in tidbitmap]
Oops, I was wrong, I supposed that all pages in chunk should be lossy, but it's 
true only for chunk page. So, tbm_add_page() should only call 
tbm_mark_page_lossy()...

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
  WWW: http://www.sigaev.ru/
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_dump Add dumping of comments on index columns
Next
From: Tom Lane
Date:
Subject: Re: GIN fast insert