Re: Additional DTrace Probes - Mailing list pgsql-hackers

It looks OK now.
Zdenek

Dne  8.03.09 21:58, Robert Lor napsal(a):

>> 2) Maybe
>>
>> TRACE_POSTGRESQL_SLRU_READPAGE_PHYSICAL_DONE(true, -1, -1);
>>
>> would be better. Because  slru_errcause, slru_errno can contains garbage
>> in situation when everything goes fine. Same for write.   
> 
> I've made the changes per your suggestion although one can argue that 
> the script can check arg0, and if it's true, avoid using arg1 and arg2 
> as they are meaningless.

Thanks.

>>  
>> I think it is committable for 8.4.
>>   
> 
> That would be awesome!

yeah, but it depends on commiters :-)
    Zdenek