Re: pgevent warnings on mingw - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: pgevent warnings on mingw
Date
Msg-id 49845D11.6050605@hagander.net
Whole thread Raw
In response to pgevent warnings on mingw  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan wrote:
> 
> I just noticed these warnings on pgevent/mingw. I guess we've probably
> been living with it for years, but it would be nice to get it clean.
> (There are also some similar warnings earlier in the build regarding
> RegisterWaitForSingleObject.)
> 
> dllwrap --def pgevent.def -o pgevent.dll pgevent.o pgmsgevent.o
> Warning: resolving _DllUnregisterServer by linking to
> _DllUnregisterServer@0
> Use --enable-stdcall-fixup to disable these warnings
> Use --disable-stdcall-fixup to disable these fixups
> Warning: resolving _DllRegisterServer by linking to _DllRegisterServer@0
> Warning: resolving _DllUnregisterServer by linking to
> _DllUnregisterServer@0
> Use --enable-stdcall-fixup to disable these warnings
> Use --disable-stdcall-fixup to disable these fixups
> Warning: resolving _DllRegisterServer by linking to _DllRegisterServer@0
> 
> What do we have to do to clean this stuff up?

Yeah, they've been there forever. This happened, IIRC, when we changed
the files to actually do what the documentation says. The commit message is:
"2) Change the pgevent DLL file so it doens't specify ordinal for the
functions. You're not supposed to do that. You're actually supposed to
declare them as PRIVATE as well, but mingw doesn't support that. VC++
will throw a warning and not an error though, so we can live with it.
"

The change was required to build at all with MSVC.

//Magnus



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: How to get SE-PostgreSQL acceptable
Next
From: KaiGai Kohei
Date:
Subject: Re: How to get SE-PostgreSQL acceptable