Re: Per database connection limit buglet - Mailing list pgsql-bugs

From Heikki Linnakangas
Subject Re: Per database connection limit buglet
Date
Msg-id 4983383F.6010909@enterprisedb.com
Whole thread Raw
In response to Re: Per database connection limit buglet  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
>> Dave Page wrote:
>>> It's possible to set a per-database connection limit of < -1, which seems bogus:
>
>> Yeah. That's simple to fix, but I'm having trouble wordsmithing the
>> error message. This is what I came up with:
>
> Why does it need to be anything except GUC's standard "invalid value"
> message?  I really don't believe that this case is worth making
> translators deal with an additional string.

I guess. The message in guc.c seems a bit cumbersome, though, so I did
create a new message for it. It's now simply "invalid connection limit: %d".

The check was missing from per-user connection limits, fixed that too.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_listener entries deleted under heavy NOTIFY load only on Windows
Next
From: "Martin Blazek"
Date:
Subject: BUG #4629: PL/pgSQL issue