Re: HAVE_FSEEKO for WIN32 - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: HAVE_FSEEKO for WIN32
Date
Msg-id 4964B47E.40106@hagander.net
Whole thread Raw
In response to Re: HAVE_FSEEKO for WIN32  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan wrote:
> 
> 
> Magnus Hagander wrote:
>> Bruce Momjian wrote:
>>  
>>> Andrew Dunstan wrote:
>>>    
>>>> Cleaning up the parallel restore patch I came across a question I
>>>> might have asked before, but one which in any case I worked around:
>>>>
>>>> Why do we carefully define fseeko() for WIN32 but then not define
>>>> HAVE_FSEEKO, which makes doing the former pretty much pointless?
>>>>       
>>> With Andrew, I have developed and applied the attached patch so MinGW
>>> handles fseeko() translation similar to Unix.
>>>
>>> Someone will need to update MSVC to have similar behavior.
>>>     
>>
>> Which is what? :-)
>>
>> It just needs to set HAVE_FSEEKO to 1 in pg_config.h?
>>
>>
>>   
> 
> Yep. I have fixed it already.

Ok, thanks!

//Magnus



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [BUGS] BUG #4186: set lc_messages does not work
Next
From: Joshua Tolley
Date:
Subject: Re: Proposed Patch to Improve Performance of Multi-BatchHash Join for Skewed Data Sets