Re: Support for array_remove and array_replace functions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Support for array_remove and array_replace functions
Date
Msg-id 4960.1342022090@sss.pgh.pa.us
Whole thread Raw
In response to Re: Support for array_remove and array_replace functions  (Marco Nenciarini <marco.nenciarini@2ndquadrant.it>)
Responses Re: Support for array_remove and array_replace functions  (Alex Hunsaker <badalex@gmail.com>)
List pgsql-hackers
Marco Nenciarini <marco.nenciarini@2ndquadrant.it> writes:
> Patch v3 attached.

I'm looking at this patch now.  The restriction of array_remove to
one-dimensional arrays seems a bit annoying.  I see the difficulty:
if the input is multi-dimensional then removing some elements could
lead to a non-rectangular array, which isn't supported.  However,
that could be dealt with by decreeing that the *result* is
one-dimensional and of the necessary length, regardless of the
dimensionality of the input.

I'm not actually certain whether that's a better definition or not.
But one less error case seems like generally a good thing.
Comments?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: Synchronous Standalone Master Redoux
Next
From: Alex Hunsaker
Date:
Subject: Re: Support for array_remove and array_replace functions