Re: new libpq SSL connection option - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: new libpq SSL connection option
Date
Msg-id 49595C5D.5050006@hagander.net
Whole thread Raw
In response to Re: new libpq SSL connection option  ("Alex Hunsaker" <badalex@gmail.com>)
Responses Re: new libpq SSL connection option
List pgsql-hackers
Alex Hunsaker wrote:
> On Sat, Dec 27, 2008 at 11:50, Andrew Chernow <ac@esilo.com> wrote:
>> Why does pqGetHomeDirectory have to succeed to use conn->sslrootcert. Maybe
>> this should be an OR of the two since sslrootcert is not dependent on
>> homedir?
>>
>> around line 970 src/interfaces/libpq/fe-secure.c
>>
>> if (conn->sslrootcert || pqGetHomeDirectory(homedir, sizeof(homedir)))
> 
> Certainly, did we miss anywhere else?

I agree it looks strange.

That said, have you actually seen a case where pqGetHomeDirectory()
fails? Or did you just notice the code?

//Magnus



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Windowing Function Patch Review -> Standard Conformance
Next
From: "David Rowley"
Date:
Subject: Re: Windowing Function Patch Review -> Standard Conformance