Re: [BUGS] BUG #4186: set lc_messages does not work - Mailing list pgsql-hackers

From Hiroshi Inoue
Subject Re: [BUGS] BUG #4186: set lc_messages does not work
Date
Msg-id 4954EEAD.2060304@tpf.co.jp
Whole thread Raw
Responses Re: [BUGS] BUG #4186: set lc_messages does not work
List pgsql-hackers
Hi,

I posted a patch 18 days ago but have got no responce.
Anyway I've simplified the patch by using an appropriate gettext module.

Hiroshi Inoue wrote:
> Bruce Momjian wrote:
>> Tom Lane wrote:
>>> Magnus Hagander <magnus@hagander.net> writes:
>>>> Thomas H. wrote:
>>>>> so at least that explains the "changed" behaviour. nevertheless, 
>>>>> LC_MESSAGES seems to be defunct - with the "locale" folder present,
>>>>> pg always picks the os' language and ignores the lc_message value.
>>>> This looks like I can reproduce though, at least on cvs head. Did this
>>>> work for you in previous versions?
>>> Maybe we were using a different build of gettext in the previous
>>> releases, one that didn't look at the same info as the current code?
>>>
>>
>> Where are we on this?

AFAICS there are 2 causes.

1. MSVC version of postgres is using a bad gettext module.
2. getenv() in mingw cannot see the result of putenv() in MSVC8.0.

As for 1, we have to use another gettext module. I can provide it
if requested.
As for 2, pg_putenv() or pg_unsetenv() in the attachced patch calls 
corresponding putenv() whose result can be referenced by getenv() in mingw.

In addtion the patch provides a functionality to Windows locale
name to ISO formatted locale name.

Comments ?

regards,
Hiroshi Inoue


pgsql-hackers by date:

Previous
From: KaiGai Kohei
Date:
Subject: Re: Updates of SE-PostgreSQL 8.4devel patches (r1348)
Next
From: Hiroshi Inoue
Date:
Subject: Re: [BUGS] BUG #4186: set lc_messages does not work