Re: pgsql: Append major version number and for libraries soname major - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Append major version number and for libraries soname major
Date
Msg-id 4947CC9A.6010609@dunslane.net
Whole thread Raw
In response to Re: pgsql: Append major version number and for libraries soname major  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers

Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
>
>> Dave Page wrote:
>>
>>> Any eta on a fix for this? My internal builds are failing as well as
>>> red_bat. (and yes, the other 2 MSVC buildfarm members are currently
>>> waiting for Dell to get hold of a new motherboard for their box).
>>>
>
>
>> I think the maintenance of the MSVC build system is the job of the,
>> well, maintainer of the MSVC build system, whoever that may be.  In
>> other words, I have no ETA for you from me.  I'd be glad, however, to
>> provide information to the maintainers.
>>
>
> I do not think this is an appropriate attitude for a committer to take.
> You are responsible for what you commit.  If you don't have the
> knowledge to fix something, or the resources to test it, okay ... but
> you then need to be proactive about getting someone else to fix/test it.
> Or else revert the broken patch.
>
>
>

I agree. I have committed an attempted fix which I discussed briefly
with Magnus.

cheers

andrew

pgsql-committers by date:

Previous
From: adunstan@postgresql.org (Andrew Dunstan)
Date:
Subject: pgsql: Attempt to fix MSVC breakage from Major Version patch.
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Make heap_update() set newtup->t_tableOid correctly, for