Re: visibility maps - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: visibility maps
Date
Msg-id 493AB715.505@enterprisedb.com
Whole thread Raw
In response to Re: visibility maps  ("Pavan Deolasee" <pavan.deolasee@gmail.com>)
List pgsql-hackers
Pavan Deolasee wrote:
> /*
>  * Size of the bitmap on each visibility map page, in bytes. There's no
>  * extra headers, so the whole page minus except for the standard page
> header
>  * is used for the bitmap.
>  */
> #define MAPSIZE (BLCKSZ - SizeOfPageHeaderData)
> 
> 
> ISTM that we should MAXALIGN the SizeOfPageHeaderData to compute MAPSIZE.
> PageGetContents() works that way and I believe that's the right thing to do.

Yep, you're right. Thanks, fixed.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: visibility maps
Next
From: Martin Pihlak
Date:
Subject: Re: SQL/MED compatible connection manager