Re: Re: pgsql: Properly unregister OpenSSL callbacks when libpq is done with - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Re: pgsql: Properly unregister OpenSSL callbacks when libpq is done with
Date
Msg-id 4937E44D.6070008@hagander.net
Whole thread Raw
In response to Re: Re: pgsql: Properly unregister OpenSSL callbacks when libpq is done with  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian wrote:
> Kris Jurka wrote:
>> Magnus Hagander wrote:
>>> Log Message:
>>> -----------
>>> Properly unregister OpenSSL callbacks when libpq is done with
>>> it's connection. This is required for applications that unload
>>> the libpq library (such as PHP) in which case we'd otherwise
>>> have pointers to these functions when they no longer exist.
>> Breaks the build with --enable-thread-safety and --with-openssl because 
>> of this typo.
> 
> Thanks, applied.

That fix is wrong.

The comment clearly says the code *shouldn't* free the lockarray, so the
proper fix is to remove those two lines.

I have applied a patch that does this.

//Magnus



pgsql-hackers by date:

Previous
From: Gregory Stark
Date:
Subject: Re: In-place upgrade: catalog side
Next
From: Gregory Stark
Date:
Subject: Re: Optimizing DISTINCT with LIMIT