Re: Patch for "Panel for Joins in the Graphic Query Builder" - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: Patch for "Panel for Joins in the Graphic Query Builder"
Date
Msg-id 49365BDF.8080409@enterprisedb.com
Whole thread Raw
In response to Re: Patch for "Panel for Joins in the Graphic Query Builder"  ("Luis Ochoa" <ziul1979@gmail.com>)
List pgadmin-hackers
Hi Luis Ochoa,

Thanks for reviewing it.
>
> A good way to access the vector, but allowing the code to access
> directly the objects based on the index probably decrease the
> independece of the subyacent structured inside the collection. If I
> decided to change the vector for a hash map in a future this operator
> probably difficult the change by example, because now we have hard
> code access directly to the structure inside the collection.
For the same reason, I have not introduced the operator [] in
gqbCollection class, but in gqbArrayCollection.
I thought - as we are able to access & insert the objects using index.
Then, why not to have direct access to the object (easy for replacement
too).

In case if one of us decide to change the vector for a hash map in a
future, the insertion of an object at a particular index will also
create the same problem, which this operator will do.
What do you say?

Sorry if I misunderstood.

And thanks for the help.

Thanks & Regards,
Ashesh


pgadmin-hackers by date:

Previous
From: "Luis Ochoa"
Date:
Subject: Re: Patch for "Panel for Joins in the Graphic Query Builder"
Next
From: Ashesh Vashi
Date:
Subject: Re: Patch for "Panel for Joins in the Graphic Query Builder"