Re: pgsql: Reduce risk of accidentally running temp-install regression tests - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Reduce risk of accidentally running temp-install regression tests
Date
Msg-id 4930618F.3000307@dunslane.net
Whole thread Raw
In response to pgsql: Reduce risk of accidentally running temp-install regression tests  (petere@postgresql.org (Peter Eisentraut))
Responses Re: pgsql: Reduce risk of accidentally running temp-install regression tests  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers

Peter Eisentraut wrote:
> Log Message:
> -----------
> Reduce risk of accidentally running temp-install regression tests against
> a mismatching installation.  Pick a default port number calculated from the
> version number, and try a few times with other numbers if that one doesn't
> work.  Check if we can connect to the port before starting our own postmaster,
> to detect some other server already running there.  To simplify the code,
> drop --temp-port option and use --port for both temp-install and pre-installed
> case.
>
> Modified Files:
> --------------
>     pgsql/src/test/regress:
>         GNUmakefile (r1.75 -> r1.76)
>         (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/GNUmakefile?r1=1.75&r2=1.76)
>         pg_regress.c (r1.53 -> r1.54)
>         (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/pg_regress.c?r1=1.53&r2=1.54)
>
>

This has apparently broken the ECPG tests - see buildfarm where multiple
members are red.

cheers

andrew

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix an oversight in uninstall_isn.sql: must drop operator
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Partial fix for fallout from temp-port changes.