Re: Re: [COMMITTERS] pgsql: Silence compiler warning about ignored return value. - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Re: [COMMITTERS] pgsql: Silence compiler warning about ignored return value.
Date
Msg-id 4925D5EA.7000608@hagander.net
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Silence compiler warning about ignored return value.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Re: [COMMITTERS] pgsql: Silence compiler warning about ignored return value.  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Tom Lane wrote:
>>> We're definitely *not* fortify-clean, although maybe trying to become so
>>> would be a good idea.  From memory, what I have seen in past builds on
>>> Red Hat systems is a lot of warnings about ignoring the return value
>>> from fwrite() and related functions.
> 
>> So. Should I revert it?
> 
> I dunno.  Was that the only such warning you got on your build?  That
> would be a bit odd given that I see many more ...

Yeah, it happens in more places. I wasn't doing a make clean first, so
that was the only one of the files that were built *that time* that gave
the warning. I see it in more places now.

I think I'll go figure out how to turn fortify off :-)

//Magnus


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Autoconf, libpq and replacement function
Next
From: Magnus Hagander
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Silence compiler warning about ignored return value.