Re: The suppress_redundant_updates_trigger() works incorrectly - Mailing list pgsql-hackers

KaiGai Kohei wrote:
> *** 80,88 ****
>            HeapTupleHeaderGetNatts(oldheader)) &&
>           ((newheader->t_infomask & ~HEAP_XACT_MASK) == 
>            (oldheader->t_infomask & ~HEAP_XACT_MASK)) &&
> !         memcmp(((char *)newheader) + offsetof(HeapTupleHeaderData, t_bits),
> !                ((char *)oldheader) + offsetof(HeapTupleHeaderData, t_bits),
> !                newtuple->t_len - offsetof(HeapTupleHeaderData, t_bits)) == 0)
>       {
>           /* ... then suppress the update */
>           rettuple = NULL;
> --- 86,94 ----
>            HeapTupleHeaderGetNatts(oldheader)) &&
>           ((newheader->t_infomask & ~HEAP_XACT_MASK) == 
>            (oldheader->t_infomask & ~HEAP_XACT_MASK)) &&
> !         memcmp(((char *)newheader) + newheader->t_hoff,
> !                ((char *)oldheader) + oldheader->t_hoff,
> !                newtuple->t_len - newheader->t_hoff) == 0)
>       {
>           /* ... then suppress the update */
>           rettuple = NULL;
>   

Wouldn't this omit comparing the null bitmap?

cheers

andrew