Re: The suppress_redundant_updates_trigger() works incorrectly - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: The suppress_redundant_updates_trigger() works incorrectly
Date
Msg-id 4911F0ED.1000008@dunslane.net
Whole thread Raw
In response to Re: The suppress_redundant_updates_trigger() works incorrectly  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

Tom Lane wrote:
> I wrote:
>   
>> Andrew Dunstan <andrew@dunslane.net> writes:
>>     
>>> OK, that will be easy enough. I assume I should still put InvalidOid 
>>> back again afterwards, in case someone downstream relies on it.
>>>       
>
>   
>> Can't imagine what ...
>>     
>
> Actually ... what *could* change in the future is that we might support
> UPDATE'ing the OID to a different value.  So what the code probably
> needs to do is something like
>
>     if (relation->rd_rel->relhasoids &&
>         !OidIsValid(HeapTupleGetOid(newtup)))
>         HeapTupleSetOid(newtup, HeapTupleGetOid(oldtup));
>
> (details stolen from heap_update)
>
>             
>   

Your wish is my command. Done.

cheers

andrew


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: The suppress_redundant_updates_trigger() works incorrectly
Next
From: Heikki Linnakangas
Date:
Subject: Toast bug in CVS HEAD