Re: pgsql: Unite ReadBufferWithFork, ReadBufferWithStrategy, and - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Unite ReadBufferWithFork, ReadBufferWithStrategy, and
Date
Msg-id 49107058.6060905@enterprisedb.com
Whole thread Raw
In response to Re: pgsql: Unite ReadBufferWithFork, ReadBufferWithStrategy, and  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: pgsql: Unite ReadBufferWithFork, ReadBufferWithStrategy, and  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-committers
Alvaro Herrera wrote:
> Hmm.  I see that some messages are now like this:
>
> (errmsg("unexpected data beyond EOF in block %u of relation %u/%u/%u/%u",
>     blockNum, smgr->smgr_rnode.spcNode, smgr->smgr_rnode.dbNode, smgr->smgr_rnode.relNode, forkNum),
>
> but it seems that the file names contain symbolic fork names, not
> numbers.  Is it possible to build the error messages so that they report
> the actual file name, or at least change the last /%u into a _%s with
> the fork name?

Agreed. There was some messages like that before, this patch just
changed some error messages I had missed before. I'll change them all to
match the file names ("%u/%u/%u_%s").

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

pgsql-committers by date:

Previous
From: h-saito@pgfoundry.org (User H-saito)
Date:
Subject: psqlodbc - psqlodbc: Fixed Soalris compiller error.
Next
From: alvherre@postgresql.org (Alvaro Herrera)
Date:
Subject: pgsql: Remove unused rfno from PLpgSQL_recfield Jonah Harris