Re: Any reason to have heap_(de)formtuple? - Mailing list pgsql-hackers

From Zdenek Kotala
Subject Re: Any reason to have heap_(de)formtuple?
Date
Msg-id 4907FB7F.8070807@sun.com
Whole thread Raw
In response to Re: Any reason to have heap_(de)formtuple?  (Kris Jurka <books@ejurka.com>)
List pgsql-hackers
Kris Jurka napsal(a):
> 
> 
> On Tue, 28 Oct 2008, Zdenek Kotala wrote:
> 
>> Kris Jurka napsal(a):
>>>
>>> Here's a patch that changes everything over to the the new API and 
>>> implements the old API by calling the new API.
>>
>> It seems to me OK. I have only one comment. I prefer to pfree 
>> allocated memory for temporary nulls array. I think that caller could 
>> call old API many times without memory context cleanup.
>>
> 
> Here's an incremental patch to add the suggested pfreeing.

I think it is ready to commit now.
Thanks Zdenek


-- 
Zdenek Kotala              Sun Microsystems
Prague, Czech Republic     http://sun.com/postgresql



pgsql-hackers by date:

Previous
From: "Joshua D. Drake"
Date:
Subject: Re: PostgreSQL + Replicator developer meeting 10/28
Next
From: Hannu Krosing
Date:
Subject: Re: PostgreSQL + Replicator developer meeting 10/28