Re: memory leak in trigger handling (since PG12) - Mailing list pgsql-hackers

From Alexander Pyhalov
Subject Re: memory leak in trigger handling (since PG12)
Date
Msg-id 48e251869b7ef921b7f894a3c7cb154a@postgrespro.ru
Whole thread Raw
In response to Re: memory leak in trigger handling (since PG12)  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Responses Re: memory leak in trigger handling (since PG12)
List pgsql-hackers
Tomas Vondra писал 2023-06-22 17:16:
> On 6/22/23 13:46, Tomas Vondra wrote:
>> ...
>> 
>> I haven't tried the reproducer, but I think I see the issue - we store
>> the bitmap as part of the event to be executed later, but the bitmap 
>> is
>> in per-tuple context and gets reset. So I guess we need to copy it 
>> into
>> the proper long-lived context (e.g. AfterTriggerEvents).
>> 
>> I'll get that fixed.
>> 
> 
> Alexander, can you try if this fixes the issue for you?
> 
> 
> regard

Hi.
The patch fixes the problem and looks good to me.
-- 
Best regards,
Alexander Pyhalov,
Postgres Professional



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: vac_truncate_clog()'s bogus check leads to bogusness
Next
From: jian he
Date:
Subject: Re: Do we want a hashset type?