Re: Fix tab completion in v18 for ALTER DATABASE/USER/ROLE ... RESET - Mailing list pgsql-hackers

On 7/30/25 12:17, Dagfinn Ilmari Mannsåker wrote:
> 
> ...
> 
>> @@ -5015,7 +5021,8 @@ match_previous_words(int pattern_id,
>>      /* Complete with a variable name */
>>      else if (TailMatches("SET|RESET") &&
>>               !TailMatches("UPDATE", MatchAny, "SET") &&
>> -             !TailMatches("ALTER", "DATABASE", MatchAny, "RESET"))
>> +             !TailMatches("ALTER", "DATABASE", MatchAny, "RESET") &&
>> +             !TailMatches("ALTER", "USER|ROLE", MatchAny, "RESET"))
>>          COMPLETE_WITH_QUERY_VERBATIM_PLUS(Query_for_list_of_set_vars,
>>                                            "CONSTRAINTS",
>>                                            "TRANSACTION",
> 
> Instead of adding another !TailMatches() call, why not just change
> "DATABASE" to "DATABASE|ROLE|USER"?

It seemed to me separate calls would be easier to understand, but I see
combine it like this in many other places, so done that way ...

Pushed. Thanks for the fixes!


regards

-- 
Tomas Vondra