Re: parallel pg_restore - WIP patch - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: parallel pg_restore - WIP patch
Date
Msg-id 48E0CADF.8000009@dunslane.net
Whole thread Raw
In response to Re: parallel pg_restore - WIP patch  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: parallel pg_restore - WIP patch  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

Tom Lane wrote:
> Stefan Kaltenbrunner <stefan@kaltenbrunner.cc> writes:
>   
>> pg_restore: [archiver (db)] could not execute query: ERROR:  deadlock 
>> detected
>> DETAIL:  Process 18100 waits for AccessExclusiveLock on relation 
>> 1460818342 of database 1460815284; blocked by process 18103.
>> Process 18103 waits for AccessExclusiveLock on relation 1460818336 of 
>> database 1460815284; blocked by process 18100.
>> HINT:  See server log for query details.
>>     
>
>   
>> ALTER TABLE ONLY foo
>>      ADD CONSTRAINT fk_av_relations_av FOREIGN KEY (vs_id) REFERENCES 
>> bar ...
>>     
>
> Hmm, I'll bet the restore code doesn't realize that this can't run in
> parallel with index creation on either table ...
>
>             
>   

Yeah. Of course, it's never needed to bother with stuff like that till now.

The very simple fix is probably to run a separate parallel cycle just 
for FKs, after the index creation.

A slightly more elegant fix would probably be to add dependencies from 
each index that might cause this to the FK constraint.

I'll work on the first for now.

Is there any chance that the locks we're taking here are too strong? 
Intuitively it looks a bit like it.

cheers

andrew


pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: [PATCHES] Infrastructure changes for recovery
Next
From: Tom Lane
Date:
Subject: Re: parallel pg_restore - WIP patch