Re: pg_settings.sourcefile patch is a security breach - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: pg_settings.sourcefile patch is a security breach
Date
Msg-id 48D694B4.3010504@hagander.net
Whole thread Raw
In response to pg_settings.sourcefile patch is a security breach  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_settings.sourcefile patch is a security breach  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Tom Lane wrote:
> We go to some lengths to prevent non-superusers from examining
> data_directory and other values that would tell them exactly where the
> PG data directory is in the server's filesystem.  The recently applied
> patch to expose full pathnames of GUC variables' source files blows a
> hole a mile wide in that.
> 
> Possible answers: don't show the path, only the file name; or
> show sourcefile/sourceline as NULL to non-superusers.

My vote goes for showing it as NULL to non-superusers. If we remove the
path, that makes it pretty darn useless for admin tools - which was the
main reason it was added in the first place..

And "showing full path for superuser, just filename for non-superusers"
just seems to be way too ugly to consider :-)

//Magnus



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: pg_settings.sourcefile patch is a security breach
Next
From: "Dmitry Koterov"
Date:
Subject: Re: Foreign key constraint for array-field?