Re: Parsing of pg_hba.conf and authentication inconsistencies - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Parsing of pg_hba.conf and authentication inconsistencies
Date
Msg-id 48CE6745.5000603@hagander.net
Whole thread Raw
In response to Re: Parsing of pg_hba.conf and authentication inconsistencies  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Parsing of pg_hba.conf and authentication inconsistencies  ("Brendan Jurd" <direvus@gmail.com>)
List pgsql-hackers
Tom Lane wrote:
> "Brendan Jurd" <direvus@gmail.com> writes:
>> Cool.  I had a look at the commitdiff and I think you missed one of
>> the error messages (it's still all on one line).  It's at
>> src/backend/libpq/hba.c line 841.  I've included a patch to split it
>> up below.
> 
> Hm, that doesn't seem like a great improvement --- in particular, it
> violates the style guideline that detail messages should be complete
> sentences.
> 
> I think the error text is all right as-is, really.

I think I need to hit myself over the head with those guidelines
repeatedly, because I think the *changed* messages are in violation of
this, and need to be changed again...

//Magnus



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Parsing of pg_hba.conf and authentication inconsistencies
Next
From: Simon Riggs
Date:
Subject: Re: rmgr hooks and contrib/rmgr_hook