Brendan Jurd wrote:
> Hi Magnus,
>
> Josh has assigned your patch to me for an initial review.
>
> First up I'd like to say that this is a really nice upgrade.
> Shielding a running server from reloading a bogus conf file makes a
> whole lot of sense.
Hi!
Thanks for your review.
> The patch doesn't include any updates to documentation. I humbly
> suggest that the change to the ident map (making "sameuser" the
> default) should be mentioned both in the Manual itself, and in the
> sample conf file comments. Here are a few sites that may be in want
> of an update:
Yes, absolutely. Thanks for the couple of pointers, that'll help me not
to miss them :-)
> The new error messages are good, but I wonder if they could be
> improved by using DETAIL segments. The guidelines on error message
> style say that the primary message should be terse and make a
> reasonable effort to fit on one line. For example, this:
>
> LOG: invalid IP address "a.b.c.d" in file
> "/home/direvus/src/postgres/inst/data/pg_hba.conf" line 77: Name or
> service not known
>
> Could be rewritten as something like this:
>
> LOG: invalid IP address "a.b.c.d" in auth config: Name or service not known
> DETAIL: In file "/home/direvus/src/postgres/inst/data/pg_hba.conf", line 77
Makes a lot of sense, I'll go about making that change.
//Magnus
