Re: pg_regress inputdir - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: pg_regress inputdir
Date
Msg-id 48C136D0.8030002@gmx.net
Whole thread Raw
In response to Re: pg_regress inputdir  (Jorgen Austvik - Sun Norway <Jorgen.Austvik@Sun.COM>)
Responses Re: pg_regress inputdir  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Jorgen Austvik - Sun Norway wrote:
> Alvaro Herrera wrote:
>> In my opinion, the need
>> for running tests outside the test dir is not very strong (or we would
>> have heard complaints before), and thus the solution is to remove
>> --inputdir and --outputdir.
> 
> Attached is a patch that removes --inputdir and --outputdir. I still 
> prefere the first patch (that fixed my problem), but removing them is 
> probably better than having them when they don't work.

There is interest among packagers to run the regression tests or other 
tests after the build.  The Red Hat RPMs have shipped a postgresql-test 
package for years with a hacked-up makefile that will probably overwrite 
random files that it shouldn't in /usr/lib.  So I would rather be in 
favor of coming up with a solution that would make this work rather than 
removing the options.  The solution would probably be adding another 
option to place the generated files, but the exact behavior would need 
to be worked out.



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Need more reviewers!
Next
From: Andrew Chernow
Date:
Subject: libpq events update