Re: fixing bug in combocid.c - Mailing list pgsql-patches

From Heikki Linnakangas
Subject Re: fixing bug in combocid.c
Date
Msg-id 48BC3AA4.7060804@enterprisedb.com
Whole thread Raw
In response to fixing bug in combocid.c  (Karl Schnaitter <karlsch@soe.ucsc.edu>)
List pgsql-patches
Karl Schnaitter wrote:
> This patch is for a bug in backend/utils/time/combocid.c.
>
> In HeapTupleHeaderAdjustCmax, the code makes the incorrect assumption
> that the raw command id corresponds to cmin, when the raw command id can
> in fact be a combo cid. It needs to be fixed to call
> HeapTupleHeaderGetCmin to get cmin. That's all there is to my patch, but
> read on for more details.

Yep. Patch committed.

Thanks for the report!

> This is my first patch; I hope I did it right!

You did well :-). No need to tar or gzip small patches like that, though.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

pgsql-patches by date:

Previous
From: ITAGAKI Takahiro
Date:
Subject: Re: rmgr hooks and contrib/rmgr_hook
Next
From: Heikki Linnakangas
Date:
Subject: Re: WIP Join Removal